Skip to content

Fix mypy errors in lu_decomposition.py #8076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Fix mypy errors in lu_decomposition.py #8076

wants to merge 5 commits into from

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

  • Fixed type hints in lu_decomposition.py to resolve mypy errors (see mypy produces errors when run on its own #8070)
  • Added explanation of LU decomposition
  • Added doctests to handle different cases in which an LU decomposition does or doesn't exist
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

github-actions and others added 5 commits January 2, 2023 01:57
updating DIRECTORY.md
f7ba9da
@tianyizheng02
Merge branch 'TheAlgorithms:master' into master
8b44f10
@tianyizheng02
Fix mypy errors in lu_decomposition.py
85ee7d6
@tianyizheng02
Replace for-loops with comprehensions
b8032f6
@tianyizheng02
Add explanation of LU decomposition and extra doctests
b7ec53f 
Add an explanation of LU decomposition with conditions for when an LU
decomposition exists

Add extra doctests to handle each of the possible conditions for when a
decomposition exists/doesn't exist
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Jan 4, 2023
@algorithms-keeper
Copy link

Multiple Pull Request Detected

@tianyizheng02, we are extremely excited that you want to submit multiple algorithms in this repository but we have a limit on how many pull request a user can keep open at a time. This is to make sure all maintainers and users focus on a limited number of pull requests at a time to maintain the quality of the code.

This pull request is being closed as the user already has an open pull request. Please focus on your previous pull request before opening another one. Thank you for your cooperation.

User opened pull requests (including this one): #8076, #8075, #8073, #8065

@algorithms-keeper algorithms-keeper bot closed this Jan 4, 2023
@tianyizheng02
Copy link
Contributor Author

tianyizheng02 commented Jan 4, 2023 •
edited
Loading

bruh

I thought the limit was 5 💀

@tianyizheng02 tianyizheng02 mentioned this pull request Jan 26, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tianyizheng02